Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link redirection is not working for VariableDeclarationUsageDistance #16290

Closed
romani opened this issue Feb 8, 2025 · 8 comments · Fixed by #16343
Closed

Link redirection is not working for VariableDeclarationUsageDistance #16290

romani opened this issue Feb 8, 2025 · 8 comments · Fixed by #16343

Comments

@romani
Copy link
Member

romani commented Feb 8, 2025

link https://checkstyle.org/config_coding.html#VariableDeclarationUsageDistance

should be redirected to
https://checkstyle.org/checks/coding/variabledeclarationusagedistance.html#VariableDeclarationUsageDistance

detected at #13038

logic for redirection:

else if (document.title.startsWith("checkstyle – Redirecting to checks/")) {

@romani romani added the approved label Feb 8, 2025
@govind516
Copy link

I would like to work on the issue. Can you please assign it to me ?

@romani
Copy link
Member Author

romani commented Feb 9, 2025

No assignments, just do comment "I am on it" and send PR

@SheikhZaeem
Copy link
Contributor

@govind516 so are you working on this issue?

@govind516
Copy link

@SheikhZaeem Yes, I am working on it.

@govind516
Copy link

Could you please provide a guide to execute the project since the documentation at https://checkstyle.org/cmdline.html shows the commands which are throwing error with "Unknown lifecycle phase". Looking for you response.

@romani
Copy link
Member Author

romani commented Feb 9, 2025

@pranavbavdhankar
Copy link
Contributor

@govind516 I would like to work on this issue!

@Zopsss
Copy link
Member

Zopsss commented Feb 15, 2025

Redirection started failing because following was the condition to check if the current page is config_xxxx.html page or not:

else if (document.title.startsWith("checkstyle – Redirecting to checks/")) {

before we upgraded maven-site-plugin the pages names' had checkstyle prefix to it but now it is not the case so redirection started failing. To make it work again, we just need to change it to Redirecting to checks, the trailing / was also unnecessary.

pranavbavdhankar added a commit to pranavbavdhankar/checkstyle that referenced this issue Feb 16, 2025
pranavbavdhankar added a commit to pranavbavdhankar/checkstyle that referenced this issue Feb 16, 2025
pranavbavdhankar added a commit to pranavbavdhankar/checkstyle that referenced this issue Feb 16, 2025
romani pushed a commit to pranavbavdhankar/checkstyle that referenced this issue Feb 19, 2025
@github-actions github-actions bot added this to the 10.21.3 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants