Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternate handling of chiral centers which have overlapping atoms or atoms on the same line #48

Open
greglandrum opened this issue Dec 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@greglandrum
Copy link
Collaborator

The standardizer currently assigns a penalty of 5 when there are overlapping atoms or 6 if there are more than six overlapping atoms. This still allows molecules which have overlapping atoms around a chiral center to pass through.

We also don't have any checks for molecules which have chiral centers with chiral atoms (atoms around a chiral center) which lie on the same line.

Here are some examples we found which have either overlapping chiral atoms (atoms around a chiral center) or chiral atoms which lie on the same line:

CHEMBL3617051
CHEMBL3590586
CHEMBL3590585
CHEMBL3590584
CHEMBL3590587
CHEMBL3752539

Since it's not possible to correctly interpret the stereochemistry of those atoms, I believe it should either be removed or the structure itself should be rejected. I'm probably going to add something to remove the stereo at the RDKit level anyway, but I think that it's worth discussion doing something about this during structure import as well.

@greglandrum greglandrum added the enhancement New feature or request label Dec 6, 2022
@eloyfelix
Copy link
Member

thanks for reporting @greglandrum. We'll be fixing those ones for the next ChEMBL release and check how we can best deal with them during the data loading phase

cc: @mdeveij @FionaEBI

@greglandrum
Copy link
Collaborator Author

@eloyfelix If you think it's worth adding a specific test for these cases to the checker, I'd be happy to write a first version for you to review

@eloyfelix
Copy link
Member

thanks @greglandrum, that would be highly appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants