Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of filter format towards 2D processing #3261

Open
lpatiny opened this issue Oct 9, 2024 · 3 comments · May be fixed by #3260
Open

Change of filter format towards 2D processing #3261

lpatiny opened this issue Oct 9, 2024 · 3 comments · May be fixed by #3260
Assignees

Comments

@lpatiny
Copy link
Member

lpatiny commented Oct 9, 2024

Currently, the filter apodization options is:

const apodization2DOptions = {
  sineBell: {
    apply: true, //false if the shape should be ignored
    shape: {
      kind: 'sineBell',
      options: {
        exponent: 2,
        offset: 0, //0.5 for cosine
      },
    },
  },
  exponential: {
    apply: true, //false if the shape should be ignored
    shape: {
      kind: 'exponential',
      options: {
        lb: 1,
      },
    },
  },
};

const apodization1DOptions =  {
  sineBell: {
    apply: true, //false if the shape should be ignored
    shape: {
      kind: 'sineBell',
      options: {
        exponent: 2,
        offset: 0, //0.5 for cosine
      },
    },
  },
  exponential: {
    apply: true, //false if the shape should be ignored
    shape: {
      kind: 'exponential',
      options: {
        lb: 1,
      },
    },
  },
};
@jobo322
Copy link
Member

jobo322 commented Oct 9, 2024

The shapes we are supporting right now are in nmr-processing apodization folder, but we should expose only:

{
  sineBell: {
    apply: true,
    shape: {
      kind: 'sineBell',
      options: { offset: 0 },
    },
  },
  sineSquare: {
    apply: true,
    shape: {
      kind: 'sineSquare',
      options: { offset: 0 },
    },
  },
  exponential: {
    apply: true,
    shape: {
      kind: 'exponential',
      options: { lb: 0.1 },
    },
  },
  lorentzToGauss: {
    apply: true,
    shape: {
      kind: 'lorentzToGauss',
      options: {
        lineBroadening: 0.1,
        gaussBroadening: 0.1,
        lineBroadeningCenter: 0,
      },
    },
  },
  modifiedGaussian: {
    apply: true,
    shape: {
      kind: 'modifiedGaussian',
      options: {
        lineBroadening: 0.1,
        gaussianBroadening: 0.1,
      },
    },
  },
  traf: {
    apply: true,
    shape: {
      kind: 'traf',
      options: { lb: 0.1 },
    },
  },
}

@jobo322
Copy link
Member

jobo322 commented Oct 9, 2024

I did an simple draw of the possible panel design, where gaussian will make reference to modifiedGaussian

Image

@lpatiny
Copy link
Member Author

lpatiny commented Oct 11, 2024

  • update the design to have checkbox
  • update nmr-processing for the new format
  • release nmr-processing
  • ask @hamed-musallam to create the graphical interface

@jobo322 jobo322 linked a pull request Oct 22, 2024 that will close this issue
@hamed-musallam hamed-musallam linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟠 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants