Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox support #17

Open
nathancahill opened this issue Mar 1, 2022 · 1 comment
Open

Firefox support #17

nathancahill opened this issue Mar 1, 2022 · 1 comment

Comments

@nathancahill
Copy link

Firefox does not support module service workers yet. Can we add a flag to change the output from esm for workers only? I think this is the relevant path:

rollup-plugin-monaco-editor/src/index.ts

Line 354 in a79288e

if (containsMonacoEntryModule && !isWorkerChunk) {

@chengcyber
Copy link
Owner

chengcyber commented Mar 3, 2022 •
edited
Loading

Hi @nathancahill , Does this option https://github.com/chengcyber/rollup-plugin-monaco-editor#esm work for you? You can set esm: false explicitly to output commonjs spec service worker code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathancahill @chengcyber