Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress pytest.PytestUnraisableExceptionWarning raised in test cleanup #735

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Nov 7, 2024

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number

Resolves #734


This change is Reviewable

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 82.54%. Comparing base (1ff20b1) to head (f526ad8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   83.67%   82.54%   -1.13%     
==========================================
  Files          28       28              
  Lines        4166     4166              
==========================================
- Hits         3486     3439      -47     
- Misses        680      727      +47     

This patch suppresses UnraisableException warnings that are
occasionally raised when using Python 3.13.
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz merged commit a9c1fe4 into cherrypy:main Nov 7, 2024
23 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

random failures when running test_conn with Python 3.13
2 participants