Close ws connections inactive for more than x seconds

[pieroit]

At the moment all ws connections remain open forever XD
We can check the old ones and close them, maybe using the WhiteRabbit by @jacopopalumbo01 or (tmp) just running a loop on active connections when a new user tries to connect, and close the old inactive ones

[pieroit]

Can be done with the WhiteRabbit

[jacopopalumbo01]

I'm here

[zAlweNy26]

I don't think the WhiteRabbit is needed.
Check this out: https://stackoverflow.com/questions/63847205/fastapi-websocket-ping-pong-timeout
and https://websockets.readthedocs.io/en/stable/topics/timeouts.html#keepalive-in-websockets (the library used under the hood)

[pieroit]

I don't think the WhiteRabbit is needed. Check this out: https://stackoverflow.com/questions/63847205/fastapi-websocket-ping-pong-timeout and https://websockets.readthedocs.io/en/stable/topics/timeouts.html#keepalive-in-websockets (the library used under the hood)

Awesome!
So I guess we just need to delete the stray once ws disconnects

core/core/cat/routes/websocket.py

Line 48 in f14f2c0

# del strays[user_id]

[pieroit]

Or there was a reason for not deleting it?
Can you remember @Pingdred ?

[Pingdred]

Or there was a reason for not deleting it?
Can you remember @Pingdred ?

We chose not to delete it just to preserve Working Memory in case of disconnection

[jacopopalumbo01]

And deleting the stray instance may arise problems when an action using the stray is scheduled in the WhiteRabbit.

[pieroit]

Proposal:
As soon as the stray is created, white rabbit will check every x minutes if it is active or not
If not, it gets deleted

Unless as @jacopopalumbo01 said there is a breaking dependency between the objects

[pieroit]

After 23/09/2024 dev meeting:

Have a new SessionManager that is used here to store, get, create and delete expired StrayCat objects

[pieroit]

Hello all, just a quick question: why not handling the ConnectionClosed exception and destroy the instance of StrayCat therein (https://websockets.readthedocs.io/en/stable/topics/keepalive.html#keepalive-in-websockets)?

Because you may lose the websocket connection but still want to reattach the same conversation

[scicco]

Hello,

I've added a feature to manage the session expiration, as @valentimarco and I suggested during a previous dev meeting.

Hope this could help

[pieroit]

PR in review, merging soon