Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile target for python support testing and some README #901

Closed
alaindargelas opened this issue Apr 1, 2023 · 3 comments · Fixed by #923
Closed

Add Makefile target for python support testing and some README #901

alaindargelas opened this issue Apr 1, 2023 · 3 comments · Fixed by #923

Comments

@alaindargelas
Copy link
Collaborator

alaindargelas commented Apr 1, 2023

@Thomasb81 , Please add a top Makeflie test target for python:

make test_python

Also add the new target in the CI Action testing:

Also, please add some documentation in the README

@Thomasb81
Copy link
Contributor

2 tests are run when UHDM is compile with BUILD_SHARED_LIBS and test are run. (integrated to ctest framework)

add_test(

add_test(

It seems to me that BUILD_SHARED_LIBS case is already integrated in workflow :

Do we need more ?
Sorry it is not clear what to do unless if it is in the perspective of #911 then it will require a specific entry in the workflow.

@alaindargelas
Copy link
Collaborator Author

alaindargelas commented Apr 16, 2023

I can't see this running in the Actions, can you point to an Action log that shows these tests are actually been executed in the CI?
I think something is missing here.
What I see is this (The build part):
https://github.com/chipsalliance/UHDM/actions/runs/4715955473/jobs/8363259020#step:14:678
But I don't see any tests running.

Also, please add a section in the README on how one would use this? (Set the compile option, run a test).

@Thomasb81
Copy link
Contributor

But I don't see any tests running.

https://github.com/chipsalliance/UHDM/actions/runs/4737059941/jobs/8409401013?pr=923#step:14:431

This aspect should be ok. Tests are run in the workflow now.

Also, please add a section in the README on how one would use this? (Set the compile option, run a test).

I add the required paragraph with python code given as example. In some way it contributes to #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants