Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove process_results item from rpc requests #54

Open
ripienaar opened this issue Nov 25, 2019 · 0 comments
Open

remove process_results item from rpc requests #54

ripienaar opened this issue Nov 25, 2019 · 0 comments

Comments

@ripienaar
Copy link
Member

Long ago we optimised the fire and forget style requests - where the client does not care for any results - by setting process_results to false/true and ensure its always in the request.

While a valid optimisation the baggage of carrying this key everywhere and remembering to handle it all the time etc is just too much for the minimal improvement in resource use it would result in for this hardly ever used pattern.

So we should kill it all, process_results should never get into any request.

See choria-legacy/mcorpc-agent-provider#126 for an example of the kind of pain this is causing, its so easy to forget its there since it seems it should be handled at a higher layer not wedged into this object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant