Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting docker cluster doesn't delete control plane #17

Open
NillsF opened this issue Nov 24, 2021 · 1 comment
Open

Deleting docker cluster doesn't delete control plane #17

NillsF opened this issue Nov 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@NillsF
Copy link
Contributor

NillsF commented Nov 24, 2021

After deleting a cluster on Docker, the delete command doesn't delete the bootstrapper container. This causes the next create-cluster to fail:

nillsf@SHRISU-YOGA ~ % gokp delete-cluster development \ 
--cluster-name=$MYCLUSTER --kubeconfig=/home/nillsf/.gokp/$MYCLUSTER/$MYCLUSTER.kubeconfig

INFO[0000] Deleting development cluster nfcluster       
INFO[0022] Cluster nfcluster successfully deleted       

nillsf@SHRISU-YOGA ~ % gokp create-cluster development \
--cluster-name=$MYCLUSTER --github-token=$GH_TOKEN

INFO[0000] Running checks                               
INFO[0000] Creating temporary control plane             
FATA[0001] node(s) already exist for a cluster with the name "gokp-bootstrapper" 
@christianh814
Copy link
Owner

I've ran into this as well. The issue is that there's no cleanup when a failed deploy happens. The initial reasoning was because, on a hyperscaler, you might have a partial install and then need the bootstrap instance there to delete any artifacts that got left behind.

We should probably figure out a "smarter" way of doing this. Open to suggestions!

@christianh814 christianh814 added the bug Something isn't working label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants