Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate cause of excessive re-rendering of list components #445

Open
kbertodatti opened this issue Aug 2, 2024 · 0 comments
Open

Investigate cause of excessive re-rendering of list components #445

kbertodatti opened this issue Aug 2, 2024 · 0 comments
Assignees
Labels
APP MyCarePlanner bug Something isn't working

Comments

@kbertodatti
Copy link
Contributor

kbertodatti commented Aug 2, 2024

When you click different tabs - any click or scroll is causing a re-render of the tab you're on. It might have something to do with mount component.

Generally what would cause this is modifying State directly and our app does this in a few places.

This issue came about very recently (in the last few weeks ~4 weeks). In the console (dev tools) watch the logging. Review commits around a month ago to see which commit has code that edits React State directly. It may not be this, but it most likely is the cause. The sort/filter functionality for example, might be a good place to start investigating.

Can also reference Dan's latest commit for a reference on the types of errors that would cause this issue.

It may also have to do with the dependencies in the use effect. If this overtriggers dependencies, that may contribute to performance issues. Need to figure out which one or two (not going to need every variable).

Ask Dan if you have questions.

--
No perceptible user experience change happening now, but users with devices that can't handle higher processing might experience lags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP MyCarePlanner bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants