Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight parsed transactions #2

Open
chvp opened this issue Sep 2, 2023 · 3 comments
Open

Syntax highlight parsed transactions #2

chvp opened this issue Sep 2, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chvp
Copy link
Owner

chvp commented Sep 2, 2023

No description provided.

@chvp chvp added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2023
Repository owner deleted a comment from salmanA169 Nov 3, 2023
@PrakashIrom
Copy link

Hi is this issue still open? If it is then please provide me in depth about the issue so that I can try fixing?

@chvp
Copy link
Owner Author

chvp commented Oct 1, 2024

This issue is still open, yes. The card for each transaction is rendered here: https://github.com/chvp/NanoLedger/blob/main/app/src/main/java/be/chvp/nanoledger/ui/main/MainActivity.kt#L218

We already have each element of the transaction in a different field, so this issue is mostly about finding good colours to assign to each element. Special care has to be taken that it works in both dark and light mode. If possible the colours should also be based on the user's Material You theme.

(And refactoring the code a bit so that a TransactionCard is a separate function wouldn't be bad either 😬)

@PrakashIrom
Copy link

Okay got it thank you!

PrakashIrom pushed a commit to PrakashIrom/NanoLedger that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants