Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Publishing Pypi package fail due to rename of ci-group package #574

Open
oliverweissl opened this issue Sep 15, 2024 · 6 comments
Open
Labels
bug Something isn't working as intended

Comments

@oliverweissl
Copy link
Member

Renaming package makes pypi publishing fail since no such package is defined there yet.

@oliverweissl oliverweissl added the bug Something isn't working as intended label Sep 15, 2024
@tckarenchiang
Copy link
Contributor

tckarenchiang commented Sep 16, 2024

It's due to the commit 13492b0, where we changed the package name from ci-group to standards, which is not registered on PyPI. I have asked @surgura to give us ownership of the PyPI projects, but he is currently in the Arctic 😅

@tckarenchiang
Copy link
Contributor

Also, it seems that specific job is being skipped. Not sure this is done manually or automatically?

@oliverweissl
Copy link
Member Author

yes you have to manually approve each release

@tckarenchiang
Copy link
Contributor

yes you have to manually approve each release

Yeah, I approved that release but what I meant is, if you look at the latest commit on the master branch, we got a green check mark because the publish job seems to have been skipped: https://github.com/ci-group/revolve2/actions/runs/10887691891/job/30210647382. Not sure how that happened.

@oliverweissl
Copy link
Member Author

ahh yes because push on master doesnt publish. only generating a release triggerst the publishing pipeline

@tckarenchiang
Copy link
Contributor

ahh yes because push on master doesnt publish. only generating a release triggerst the publishing pipeline

Ah I see it in the workflow now. Only a tag push can trigger the publish job. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants