CMakeLists.txt file is out of date

[tlanc007]

The project is pulling in a very ancient version of Boost. Work is needed to be able to use the current version of boost. Additionally, some of the tests won't build due to compile errors.

[jefftrull]

On the second part, can you clarify whether the tests fail to build with the "ancient" version of Boost, or with the current one? And what is your platform/compiler version? Thanks.

[tlanc007]

I need to double check with Michael, but I thought he tried a slightly older version and it failed, too. Also, I thought he said he fixed the issue. So don't spend any more time on this until, until I follow up.

Platform: MacOS 10.13
Compiler: Clang 7.0

[tlanc007]

Michael says HEAD should compile now. So, I'm going to close this out.

[tlanc007]

The other combination that was tried was Clang-7.0 and boost 1.67.

[tlanc007]

I prematurely closed the issue. The portion about the tests not building should now be handled. But the CMake file still could use an update.

[jefftrull]

So it doesn't look like the project "pulls in" any particular Boost version. It does stipulate a minimum version, though. Is that no longer OK (because of changed APIs etc.)?

And the tests aren't building for me on develop :)

[tlanc007]

Ok, then this is just my not understanding/trusting the version clause of find_package. Without looking at each package's usage of the version it is hard to say exactly what cmake will do with it. So if it is going to just make use of the most current version of boost that is found at the time the command is run, then the version can be left alone.

[jefftrull]

Yep, as long as it's after 1.53.

I'm finding that the mustache_end2end test fails to compile - you too? Something about the recursive variant and std::pair...

[tlanc007]

On develop, all the tests build. But mustache_end2end doesn't pass when running the tests.

I am building under C++17 though