Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concourse-export does not properly escape double quotes within a field #499

Open
jtnelson opened this issue Apr 10, 2024 · 0 comments
Open

Comments

@jtnelson
Copy link
Member

In concourse-export, if a field contains spaces and double quotes, then the field is wrapped in single quotes. However, this does not conform to specification and causes issues when the data is reimported.

https://stackoverflow.com/questions/17808511/how-to-properly-escape-a-double-quote-in-csv

The fix should be to make sure that double quotes are escaped according to specification and also check the import framework to make sure that it properly handles what is expected.

The offending line is

AnyStrings.ensureWithinQuotesIfNeeded($value, delimiter));

Perhaps use https://commons.apache.org/proper/commons-csv/ instead of building this ourselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant