Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Hosting discovery: Caching #2940

Open
4 tasks
abroddrick opened this issue Oct 15, 2024 · 0 comments
Open
4 tasks

DNS Hosting discovery: Caching #2940

abroddrick opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
dev Feature: 🌐 DNS Management Nameservers, and eventually DNS Hosting-related functionality

Comments

@abroddrick
Copy link
Contributor

Issue description

We will be adding in the cloudflare Tenant api to use for setting and retrieving dns records. We will send the commands to "put" dns records in their system, while we will be saving these in our database it's imperative that we make sure to routinely do a get (or read) call to retreive what cloudflare has stored and update our system if there is ever a discrepancy. That said, when doing these get calls we should look at caching the response for a short time, as caching on “gets” to a third party api is common practice, especially when things shouldn’t be constantly changing. Caching should always be reset when we do a command that we know may change data (ie create, update, delete). The main questions for this investigation is how to cache and how long to hold onto the cache.

Assume for now that the cache will be added on get calls, you do not need to further investigate what gets cached.

Acceptance criteria

  • read, update and add to the current options for caching as is applicable (feel free to add another option if one jumps out at you)
  • Update the architecture impacts section indicating the choice made from the options (see additional details)
  • determine which option to go with and get feedback from other engineers to evaluate your decision
  • update the decision log with your decision

Additional context

For updating the architecture impacts, it can be as simple as writing "on all get calls we should add XYZ and then on all calls setting data we should clear the cache by doing abc". Feel free to include code snippets from docs as needed.

Links to other issues

@abroddrick abroddrick added dev Feature: 🌐 DNS Management Nameservers, and eventually DNS Hosting-related functionality labels Oct 15, 2024
@abroddrick abroddrick added this to the c | DNS Hosting milestone Oct 15, 2024
@vickyszuchin vickyszuchin changed the title DNS Hosting discover: Caching DNS Hosting discovery: Caching Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Feature: 🌐 DNS Management Nameservers, and eventually DNS Hosting-related functionality
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants