Use dedicated struct for wallet balance.

[KnowWhoami]

Description:

Right now, our cli-apps have many rpc commands for showing balances of each utxo type and their total as shown below :

1. maker-cli:
   

   coinswap/src/bin/maker-cli.rs

   Lines 34 to 40 in ee050ee

   	SeedBalance,
   	/// Returns the total swap coin balance
   	SwapBalance,
   	/// Returns the total live contract balance
   	ContractBalance,
   	/// Returns the total fidelity balance
   	FidelityBalance,

2. taker-cli:
   

   coinswap/src/bin/taker.rs

   Lines 68 to 74 in ee050ee

   	SeedBalance,
   	/// Returns the total swap coin balance
   	SwapBalance,
   	/// Returns the total live contract balance
   	ContractBalance,
   	/// Returns the total balance of taker wallet
   	TotalBalance,

Due to which , these cli-apps now have many rpc commands and could become a bad UX from user perspective as they would have to call different command to see a particular utxo balance.
Also TotalBalance rpc command in taker cli app -> just show the total balance of the wallet -> It doesn't denote that which utxos type contribute to how much balance , which the user manually have to calculate by juggling among these rpc commands.

Proposed Solution:

Instead, we can have a dedicated struct for denoting balances of each type as:

struct Balance {
    seed: Amount,
    swap: Amount,
    contract: Amount,
    fidelity: Amount,
    spendable:Amount
}

This struct would remove redundancy as we just to need to have single rpc command get-balance which would give balance of the wallet in this format , describing all the balance info , which a user must need to know.

[Levi0804]

Hello, can I take this one and work on it?

[mojoX911]

Sure give it a shot.

[Levi0804]

Hey, I noticed the files mentioned in this issue have changed, especially the variants of the Command enum. Could you update the details to reflect the current state? thanks!

[mojoX911]

Current structure is mostly the same with some name changes. Irrespective of that the new balance structure will look as below.

struct Balance {
    regular: Amount, #aka seed balance
    swap: Amount, #only the incoming swap coin balance
    contract: Amount, #all unfinished timelock contract balance. 
    fidelity: Amount, #this only applies to the maker.
    spendable:Amount #seed + swap balance
}

You wanna build on top of #380 as some new APIs for calculating the above ones are added there.

[Levi0804]

I have started working on the maker cli part and I was wondering if it’s okay to push the incomplete changes for you to take a look. It would be great to know if I’m heading in the right direction before I proceed further.

[mojoX911]

Sure, open up a PR.

[Levi0804]

@mojoX911 I created a PR #385