-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS should send ACK to maker address posting #401
Comments
After updating/inserting the address: coinswap/src/market/directory.rs Lines 486 to 488 in 6ee6dd6
we can send ACK and then handle reading it on the maker side. Am I correct? |
based on successful operation send an ACK or NACK. Just expand the result and send the payload accordingly. |
if let Err(e) = directory.updated_address_map((metadata.url, metadata.proof.bond.outpoint)) {
log::warn!(
"NACK. Posting request by maker was rejected by DNS: {:?}",
e
);
send_message(stream, &"NACK")?;
return Err(e);
}
log::info!("ACK. Posting request by maker was accepted by DNS.");
send_message(stream, &"ACK")?; so something like this, right? |
have response type as enum and use match |
I created a PR #414 Please let me know your thoughts on it. |
Currently, the maker has no way of knowing if their address posting request are successfully stored by DNS.
make the DNS send back an ACK message to maker.
The text was updated successfully, but these errors were encountered: