Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: deprecate test loader #1109

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Jan 21, 2024

No description provided.

@bbortt bbortt self-assigned this Jan 21, 2024

import static java.util.Optional.ofNullable;

public final class SystemProvider {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also contained in #1075

return xmlSource;
}

return xmlSource.replace("<test ", String.format("<test xmlns=\"%s\" ", TEST_NS));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return xmlSource.replace("<test ", String.format("<test xmlns=\"%s\" ", TEST_NS));
return xmlSource.replace("<test ", format("<test xmlns=\"%s\" ", TEST_NS));

@@ -589,3 +589,58 @@ on a dedicated local context. See the *global-context* attribute that is set to

After that template instances won't influence each other anymore. But notice that variable changes inside the template then
do not affect the test case neither.

[[xml-sharded]]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this chapter is obsolet

//DEPS org.citrusframework:citrus-jbang:${citrus.jbang.version:4.2.0-SNAPSHOT}
//DEPS org.citrusframework:citrus-groovy:${citrus.jbang.version:4.2.0-SNAPSHOT}
//DEPS org.citrusframework:citrus-xml:${citrus.jbang.version:4.2.0-SNAPSHOT}
//DEPS org.citrusframework:citrus-yaml:${citrus.jbang.version:4.2.0-SNAPSHOT}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@christophd christophd marked this pull request as draft May 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant