-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotations marks in text for a change #48
Comments
Works for me. Can you provide a changelog file that demonstrates the issue? |
Sure, here is one with screenshot of what I see (on Android 7.1.2 (LineageOS 14.1-20171214-NIGHTLY-klte), minSdkVersion 16, targetSDKVersion 26). |
Looks like this works fine with AAPT, but is an issue when using AAPT2. Using The contents of the <release version="2.2" versioncode="13" >
<change>&quot;Normal quotes&quot;</change>
<change>“unicode quotes”</change>
<change>&apos;Single quotes&apos;</change>
<change>‘Unicode single quotes’</change>
</release> Alternatively, you could disable aapt2 as described here: https://developer.android.com/studio/build/gradle-plugin-3-0-0.html Issue in Google's bug tracker: https://issuetracker.google.com/issues/71805084 |
Okay, thanks for the quick investigation. Probably using the proper unicode symbols for quotes doesn't hurt either ;). But why does it work in Anyway, just make sure to note it in your documentation if the problem cannot be solved. |
This is mostly due to AAPT(2) optimizing files in res/xml/ and there's no guarantee this won't break our files. Sadly, there has been at least one bug that affected ckChangeLog. See issue #48.
In the
<change>
tags, using quotation marks as"
or escaped as\"
or even as\u0022
does not show the symbol in the dialog, there is no character instead. In Android resources this works (e.g. instrings.xml
). Single quotes'
even cause the whole text following to be removed.Using the actual characters
„ “ ” ‚ ‘ ’
works, however.The text was updated successfully, but these errors were encountered: