Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing a view now auto-record appConfiguration #204

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

keighrim
Copy link
Member

fixes #166

* updated to `mmif-python==1.0.11`
* parameter type casting now happens in `ClamsApp` class, instead of on the restifier wrapper layer (updated all test cases for this)
* all "raw" parameters passed to the app are now assumed to be a list of string values, directly from `flask.request.args.to_dict(flat=False)`
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 91.58879% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.87%. Comparing base (0edf198) to head (3462b54).

Files Patch % Lines
clams/appmetadata/__init__.py 57.14% 6 Missing ⚠️
clams/app/__init__.py 96.55% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    74.49%   73.87%   -0.62%     
===========================================
  Files            9        9              
  Lines          745      758      +13     
===========================================
+ Hits           555      560       +5     
- Misses         190      198       +8     
Flag Coverage Δ
unittests 73.87% <91.58%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim merged commit 0daa225 into develop Mar 31, 2024
4 checks passed
@keighrim keighrim deleted the 166-record-appconfig branch March 31, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

sign_view and get_configuration
1 participant