Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed multivalued parameter values were not correctly recorded in output MMIF #215

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

keighrim
Copy link
Member

fixes #214

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (faf001f) to head (8c882b8).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
+ Coverage    73.55%   73.66%   +0.10%     
===========================================
  Files            9        9              
  Lines          745      748       +3     
===========================================
+ Hits           548      551       +3     
  Misses         197      197              
Flag Coverage Δ
unittests 73.66% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim merged commit e28d833 into develop Apr 21, 2024
5 checks passed
@keighrim keighrim deleted the 214-fix-MVparam-viewmetadata branch April 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

views[].metadata.parameters record only the first value for multivalued=T params
1 participant