-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split centres.xml across the individual recommendations? #247
Comments
To be sure: I suggest that each Being able to use the attribute |
Ah, incidentally, the |
Eliza will move centre elements to the recommendation files. |
I will add the element as optional, for the time being, to the schema for recommendations. After the move, I'll make it obligatory. |
…nge the former "centre" to "centreID" - references #249
I mean in in export files when the format recommendations are not filtered by centreID, e.g.
|
I have added centre elements in the recommendation files and updated the code to use them instead of the centres.xml. Please check the dev branch. |
* Added domains of recommendations in centre pages (close clarin-eric#240) * Implemented multiple curators (clarin-eric#238) * Updated the style of multiple curators and added an example (clarin-eric#238) * Make base URL semi dynamic (close clarin-eric#248) * Added domains of recommendations in format pages (clarin-eric#240) * addresses clarin-eric#238 * KP-7936 Update FIN-CLARIN-recommendation.xml We went through all functional domains and added formats as we saw relevant. We skipped domains we deemed not relevant to Kielipankki. * add jussi + stub for <info> * make "centre" optional (for now) in the header - addresses clarin-eric#247 , change the former "centre" to "centreID" - references clarin-eric#249 * change "centre" to "centreID" in the filter field - addresses clarin-eric#249 * Fixed centreID. * Added centre elements in recommendation files (clarin-eric#247) * Updated references from filter/centre to filter/centreID (clarin-eric#249) * Updated centre model to use recommendation files instead of centres.xml (clarin-eric#247) * Added SAW recommendation (clarin-eric#247) * add "centreID" as an optional child of "format", with an annotation stating its purpose; see clarin-eric#249 (comment) * KP-7936 add PDF for documentation, add review date * KP-7936 remove PDF* for textual src lang data * KP-7936 add info text based on Språkbanken * KP-7936 Update FIN-CLARIN-recommendation.xml We went through all functional domains and added formats as we saw relevant. We skipped domains we deemed not relevant to Kielipankki. * add jussi + stub for <info> * KP-7936 add PDF for documentation, add review date * KP-7936 remove PDF* for textual src lang data * KP-7936 add info text based on Språkbanken * KP-7936 fix indent --------- Co-authored-by: margaretha <[email protected]> Co-authored-by: piotr <piotr@bodysek>
Ah, I was wondering when I saw the duplicated info, both in |
It's mid-May so I am going to have a look now and most probably close it. |
Don't want to close the ticket yet, because the info is still duplicated. I suggest that we remove centres.xml after the upcoming release and then deal with potential consequences. I'm moving this ticket to 2.8.0; it already has the priority label. Edit: oh let me wait with the milestone switch until tomorrow (May 24th). Maybe we can remove centres.xml right away. |
I am not sure if we can find serious arguments against keeping the centre info separate from the recommendations.
Currently, we list 51 centres and have 52 recommendation documents, and that's already a yellow blinking light.
Each recommendation tells us something about the single centre, they are connected implicitly, via the file name. So, the info on the IDS in
centres.xml
is:... and the filename of the recommendations is
IDS-recommendation.xml
. The recommendation file has a header, currently set to the following (and note the redundance between the file name and thefilter
element):(where the maintainer info was added for the sake of a demo at CAC-2023 and I don't consider it binding...)
Arguments for merging:
centre
element and the relevant recommendation file should always be 1:1<formats>
:<formats ri="dariah">
would be DARIAH-specific while<formats>
would go for all the RIs involved. (this is not yet technically possible and won't be until we see the need for such an arrangement; but it would be good to have the base for that in place)Argument against: technical complexity and bugs cropping up after the rearrangement, but that's a non-argument, really. It might be an argument for releasing 3.0.
The text was updated successfully, but these errors were encountered: