Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPI page: enhancement needed #273

Open
bansp opened this issue May 24, 2024 · 6 comments
Open

KPI page: enhancement needed #273

bansp opened this issue May 24, 2024 · 6 comments
Assignees
Labels
homework stuff to think about actively between meetings SIS:centres centre-oriented part of the SIS SIS:functionality
Milestone

Comments

@bansp
Copy link
Member

bansp commented May 24, 2024

  1. It seems to me that we need a date stamp for the KPI calculation.
  2. We also need to make this calculation easy to verify, so the phrase "depositing centres" needs to link to the list of exactly those centres that we use for calculation.
  3. The last paragraph has become gibberish. It needs to be fixed ASAP, before release 2.7.0.
@bansp bansp added SIS:functionality SIS:centres centre-oriented part of the SIS labels May 24, 2024
@bansp bansp added this to the SIS v. 2.8.0 milestone May 24, 2024
@bansp
Copy link
Member Author

bansp commented May 24, 2024

Regarding point (3) above,

The SIS provides information on all <a href="{app:link("views/list-centres.xq")}">centres that allow
                                    for data depositions</a>

lacks the appropriate filter for centres that allow data deposition.
(Apart from that, the "all" is a bit bold and needs to be even further qualified. "All CLARIN" seems the easiest to do.)

@bansp
Copy link
Member Author

bansp commented May 24, 2024

  1. This is wrong, isn't it:
<td class="column">CLARIN deposition centres recorded in the SIS</td>
<td class="column">{$numOfBCentres}</td>

We've been through this for the paper (when recalculating the KPI at the time of submission), but we may have forgotten (?) to modify the KPI page as well.

bansp pushed a commit that referenced this issue May 24, 2024
@bansp
Copy link
Member Author

bansp commented May 27, 2024

I have handled point 3., and point 4. was just a misnamed variable, fixed on the way to release 2.7.0.

@margaretha margaretha assigned margaretha and unassigned margaretha Aug 8, 2024
@margaretha
Copy link
Collaborator

We can add current timestamp for the KPI calculation.

@margaretha margaretha self-assigned this Aug 21, 2024
@margaretha margaretha added the homework stuff to think about actively between meetings label Sep 19, 2024
margaretha added a commit that referenced this issue Sep 23, 2024
@margaretha
Copy link
Collaborator

I have added a date stamp addressing point 1.

To which page should "depositing centres" link? Centre or Centre Statistics page?

@bansp
Copy link
Member Author

bansp commented Sep 26, 2024

Meeting decision: the KPI page should link to the centre statistics page, and that other page should get a new column, for those centres that have provided information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
homework stuff to think about actively between meetings SIS:centres centre-oriented part of the SIS SIS:functionality
Projects
None yet
Development

No branches or pull requests

2 participants