Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the File Name of the Outline can cause Multiple Saves to Different Files #7

Open
clartaq opened this issue Jun 7, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@clartaq
Copy link
Owner

clartaq commented Jun 7, 2021

If a pause occurs when entering a title, a file with the name that appears in the edit box will be saved. Files can be saved before the complete title is entered.

@clartaq clartaq self-assigned this Jun 7, 2021
@clartaq clartaq added the bug Something isn't working label Jun 7, 2021
@clartaq
Copy link
Owner Author

clartaq commented Jun 7, 2021

The auto-save feature should not be active on the title edit box. Maybe do the save when the title edit control loses focus.

@clartaq clartaq changed the title Editing Title can cause Multiple Saves to Different Files Editing the File Name of the Outline can cause Multiple Saves to Different Files Jun 7, 2021
@clartaq
Copy link
Owner Author

clartaq commented Jun 7, 2021

As the change in the issue indicates, this bug is actually caused by "slow" editing of the file name, not the title.

@clartaq
Copy link
Owner Author

clartaq commented Jun 7, 2021

Editing the file name currently uses an autosave mechanism similar to that attached to text elsewhere in the document. As such, after a period of inactivity, any changes to the text in the control cause the file to be saved with the new name.

Slow typing can cause multiple versions of the file to be saved with differing file names.

@clartaq
Copy link
Owner Author

clartaq commented Jun 7, 2021

The best way to handle file name changes is to wait until the user stops typing and switches to a different control. When the loss of focus (blur) occurs, mark the document as dirty and autosave as usual.

clartaq added a commit that referenced this issue Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant