-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixer needs to be able to set a persistent --offline option in the builder.conf #453
Comments
I can incorporate this in my current patch since I'm already working on --offline code paths. |
some TC that come to mind. 1.Generate a working directory with mixer --offline option enabled and persistent. Add bundles and build, disable any connection to the outer network. a.Expected result: Mixer should never try to connect or fail. 2.Execute step 1 then Update your Clear linux version using swupd update, then mix, add bundles, remove, build. a.Expected result: Again mixer should not attempt to connect upstream. 3.Execute step 1 then Update even into another format bump, try to mix, add bundles, build. a.Expected result: again mixer should not attempt to connect upstream. 4.Execute step 1 then, try unsetting the offline flag, mix, build, add remove bundles. Then try to set the permanent --offline flag. Expected result: Mixer should connect when offline flag is unset and not connect when it is set. Mixer should be able to set and unset this flag at users will. |
@rchiossi can you write some updates on this? |
There are currently 3 things left to get persistent offline working: I'm finishing item 1 and item 3 is trivial once the rest is in. I already have bat tests ready for this and I've also tested mixer.state conversion once the property is added. The only thing that might take some time is item 2. The problem is preserving the current text output of that command, but if we don't care too much about it and just force set in offline mode, then the fix is also quite simple. I believe there is no big blocker that would prevent us from having it integrated by next release. |
@rchiossi great, I agree with your plan ^ |
@rchiossi If this is not a requirement any more, can we close this? |
From the upstream side, this is not a requirement anymore. Automation that we're writing with clr-distro-factory will be written in a way to easily accommodate this as it is today. Plus, the number of upstream users is going to be very very small. And if there are others, we'll be referring them to clr-distro-factory. The likelihood of users running mixer interactively at the command prompt as an upstream and potentially wanting this is also going to be very very small, if existent. I'd also like to see this option not be more cemented into mixer's configuration in response to #627 since it would be great if we could remove the |
Yes, i believe we can close this one. As George stated, our requirements have changed. |
Requirement removed by clearlinux/clr-distro-factory#51 |
Some users are pure upstreams, meaning they do not EVER want to go online for any mixer operation. The content and infrastructure even for regular downstream users may require them to work locally only because of network issues/security, so making this persist without having to constantly call the flag on every command will be required.
The text was updated successfully, but these errors were encountered: