New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old Clerk v1 code but Clerk v2 is used #88

Open

mmenozzi opened this issue Oct 26, 2020 · 0 comments

Contributor

mmenozzi commented Oct 26, 2020

clerk-magento/skin/helper.js

Lines 62 to 68 in 6871b8a

    
           function clerk_fire_power_popup() { 
        
               Clerk.ui.popup('#clerk-power-popup').show(); 
        
           } 
        
           function clerk_close_power_popup() { 
        
               Clerk.ui.popup('#clerk-power-popup').close(); 
        
           }

The code above still use the old syntax of Clerk v1. It should be the following in Clerk v2:

 function clerk_fire_power_popup() { 
     Clerk('ui', 'popup', '#clerk-power-popup', 'show');
 } 
  
 function clerk_close_power_popup() { 
     Clerk('ui', 'popup', '#clerk-power-popup', 'hide');
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment