Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Laravel 11 support #76

Merged
merged 5 commits into from
Mar 15, 2024
Merged

chore: Laravel 11 support #76

merged 5 commits into from
Mar 15, 2024

Conversation

faytekin
Copy link
Contributor

No description provided.

@bykof
Copy link

bykof commented Mar 14, 2024

LGTM

@faytekin faytekin requested a review from bykof March 14, 2024 13:53
@saibotk
Copy link
Member

saibotk commented Mar 15, 2024

Hey 👋 thanks for your work, i've just updated the dependencies in other PRs so pint etc does not clutter this PR.

Would you be able to rebase your changes on the latest main branch?

Otherwise, I can take over.

Thank you very much ✌️

@faytekin
Merge branch 'main' of https://github.com/clickbar/laravel-magellan i…
26daf64 
…nto build/laravel-11x

# Conflicts:
#	CHANGELOG.md
#	composer.json
#	composer.lock
@faytekin
Copy link
Contributor Author

Hey 👋 thanks for your work, i've just updated the dependencies in other PRs so pint etc does not clutter this PR.

Would you be able to rebase your changes on the latest main branch?

Otherwise, I can take over.

Thank you very much ✌️

@saibotk Done 🚀

@saibotk
Copy link
Member

saibotk commented Mar 15, 2024 •
edited
Loading

Perfect, looks good. Can you just add some phpstan ignores to the doctrine type calls? Then we are good to go 💅

@faytekin
Copy link
Contributor Author

Sure thing! Just added the PHPStan ignores for the Doctrine type calls as suggested. Ready to merge whenever you are! 😊🚀

@saibotk saibotk merged commit 8297516 into clickbar:main Mar 15, 2024
35 checks passed
@faytekin
Copy link
Contributor Author

@saibotk Just wanted to check on the Laravel 11 support pull request. It’s merged for a couple of days now. Can we expect a release soon? Thanks! 👍🚀

@faytekin faytekin deleted the build/laravel-11x branch March 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bykof bykof bykof approved these changes

@saibotk saibotk saibotk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faytekin @bykof @saibotk