Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this project still supported? #197

Open
alexandear opened this issue Feb 8, 2023 · 1 comment
Open

Is this project still supported? #197

alexandear opened this issue Feb 8, 2023 · 1 comment

Comments

@alexandear
Copy link

alexandear commented Feb 8, 2023 •
edited
Loading

I'm curious if this project is maintained. Looks like isn't.

What I see:

  • The latest commit and release was on Mar 9, 2018.
  • There are 42 non-closed issues.
  • misspell has 29 open pull requests.
jbampton added a commit to jbampton/mruby that referenced this issue Mar 1, 2023
@jbampton
Remove misspell and update CONTRIBUTING.md
2559c93 
It looks like `misspell` is no longer maintained and
the last commit was on `Mar 9, 2018`.

We already run `codespell` and it is an active project
with the last commit 5 days ago.

Also updated the CONTRIBUTING guide with more
information on `pre-commit` as well as listed `codespell`
as the spell checker.

https://github.com/codespell-project/codespell
https://github.com/client9/misspell
client9/misspell#197
@jbampton jbampton mentioned this issue Mar 1, 2023
Merged
@ldez
Copy link

ldez commented Jun 19, 2023

We (the golangci-lint team) maintain a fork https://github.com/golangci/misspell

@ldez ldez mentioned this issue Aug 21, 2023
Closed
@ccoVeille ccoVeille mentioned this issue Apr 17, 2024
Closed
VannTen added a commit to VannTen/kubespray that referenced this issue May 22, 2024
@VannTen
Convert check_typo to pre-commit + use maintained version
9f680bd 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
VannTen added a commit to VannTen/kubespray that referenced this issue May 28, 2024
@VannTen
Convert check_typo to pre-commit + use maintained version
7f7b65d 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
ehsan310 pushed a commit to ehsan310/kubespray that referenced this issue May 31, 2024
@VannTen @ehsan310
Convert check_typo to pre-commit + use maintained version
e7d6fb7 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this issue Jun 26, 2024
@VannTen @Rickkwa
Convert check_typo to pre-commit + use maintained version
b9cdeed 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/kubespray that referenced this issue Jul 7, 2024
@VannTen
Convert check_typo to pre-commit + use maintained version
dec3c14 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/kubespray that referenced this issue Jul 11, 2024
@VannTen
Convert check_typo to pre-commit + use maintained version
021e4fe 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
k8s-ci-robot pushed a commit to kubernetes-sigs/kubespray that referenced this issue Jul 12, 2024
@k8s-infra-cherrypick-robot @VannTen
[release-2.25] pre-commit: make hooks self contained + ci config (#11359
9b122fb 
)

* Use alternate self-sufficient shellcheck precommit

This pre-commit does not require prerequisite on the host, making it
easier to run in CI workflows.

* Switch to upstream ansible-lint pre-commit hook

This way, the hook is self contained and does not depend on a previous
virtualenv installation.

* pre-commit: fix hooks dependencies

- ansible-syntax-check
- tox-inventory-builder
- jinja-syntax-check

* Fix ci-matrix pre-commit hook

- Remove dependency of pydblite which fails to setup on recent pythons
- Discard shell script and put everything into pre-commit

* pre-commit: apply autofixes hooks and fix the rest manually

- markdownlint (manual fix)
- end-of-file-fixer
- requirements-txt-fixer
- trailing-whitespace

* Convert check_typo to pre-commit + use maintained version

client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.

* collection-build-install convert to pre-commit

* Run pre-commit hooks in dynamic pipeline

Use gitlab dynamic child pipelines feature to have one source of truth
for the pre-commit jobs, the pre-commit config file.

Use one cache per pre-commit. This should reduce the "fetching cache"
time steps in gitlab-ci, since each job will have a separate cache with
only its hook installed.

* Remove gitlab-ci job done in pre-commit

* pre-commit: adjust mardownlint default, md fixes

Use a style file as recommended by upstream. This makes for only one
source of truth.
Conserve previous upstream default for MD007 (upstream default changed
here markdownlint/markdownlint#373)

* Update pre-commit hooks

---------

Co-authored-by: Max Gautier <[email protected]>
davidumea pushed a commit to elastisys/kubespray that referenced this issue Oct 25, 2024
@VannTen @davidumea
Convert check_typo to pre-commit + use maintained version
aa679c7 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandear @ldez