Need to read config properly

[yunkon-kim]

What would you like to be enhanced
: I'd like to read config properly.

Why is this needed
: The config setting code is redundant in many init().

Proposed solution
:

[ChobobDev]

I would like to know more about this issue since I am interested in working on this topic.

Thank you

[yunkon-kim]

@ChobobDev I'm happy to hear that 😄

I'm looking for a nice way to set configs.

At the very beginning, I wanted to protect critical information and modify it easily by users so that I create the below configs.

• config.yaml for poc-cb-net
• log_conf.yaml for cb-log (external package)

With these configs, users can run several executable files (e.g., admin-web, controller, agent, clad-service) in any directory. (CB-Larva, which aims for microservice architecture, is divided into executable files.) Even when I run the controller on a Docker container, it's fine ^^

But... The problem is that I have many duplicated init() functions... That's why I'm looking for a nice way to set configs.

I would like to follow Golang's package programming philosophy and discuss ways to improve it with you ^^

If you have any further questions, comments, and concerns, feel free to tell me 😄

[yunkon-kim]

[Additional description]

On develop branch, below files have related init() function.

• admin-web.go
• agent.go
• controller.go
• cladnet-service.go
• test-client.go
• cb-network.go
• networking-rule.go

An example of init() (Each init() would be slightly different.)

func init() {
	fmt.Println("Start......... init() of controller.go")
	ex, err := os.Executable()
	if err != nil {
		panic(err)
	}
	exePath := filepath.Dir(ex)
	fmt.Printf("exePath: %v\n", exePath)

	// Load cb-log config from the current directory (usually for the production)
	logConfPath := filepath.Join(exePath, "config", "log_conf.yaml")
	fmt.Printf("logConfPath: %v\n", logConfPath)
	if !file.Exists(logConfPath) {
		// Load cb-log config from the project directory (usually for development)
		path, err := exec.Command("git", "rev-parse", "--show-toplevel").Output()
		if err != nil {
			panic(err)
		}
		projectPath := strings.TrimSpace(string(path))
		logConfPath = filepath.Join(projectPath, "poc-cb-net", "config", "log_conf.yaml")
	}
	CBLogger = cblog.GetLoggerWithConfigPath("cb-network", logConfPath)
	CBLogger.Debugf("Load %v", logConfPath)

	// Load cb-network config from the current directory (usually for the production)
	configPath := filepath.Join(exePath, "config", "config.yaml")
	fmt.Printf("configPath: %v\n", configPath)
	if !file.Exists(configPath) {
		// Load cb-network config from the project directory (usually for the development)
		path, err := exec.Command("git", "rev-parse", "--show-toplevel").Output()
		if err != nil {
			panic(err)
		}
		projectPath := strings.TrimSpace(string(path))
		configPath = filepath.Join(projectPath, "poc-cb-net", "config", "config.yaml")
	}
	config, _ = model.LoadConfig(configPath)
	CBLogger.Debugf("Load %v", configPath)
	fmt.Println("End......... init() of controller.go")
}

[yunkon-kim]

Hi, @ChobobDev

If you are working on this issue, could you share your progress? 😄

[ChobobDev]

I am sorry @hermitkim1 I am still trying to understand this issue.
So I do not have clear progress on this issue.
I would love to ask for your warm understanding.

Thank You

[yunkon-kim]

@ChobobDev, I fully understand your difficulty on this issue ☺️

If you have any discussion points, feel free to tell me.