Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for no_nodejs_compat_v2 compatibility flag #17608

Open
UpliftMacaw opened this issue Oct 17, 2024 · 5 comments · May be fixed by #18765
Open

Add documentation for no_nodejs_compat_v2 compatibility flag #17608

UpliftMacaw opened this issue Oct 17, 2024 · 5 comments · May be fixed by #18765
Assignees
@jasnell @irvinebroque @mikenomitch @GregBrimble @ToriLindsay
Labels
content:edit Request for content edits documentation Documentation edits product:workers Related to Workers product

Comments

@UpliftMacaw
Copy link
Contributor

Existing documentation URL(s)

What changes are you suggesting?

With the nodejs_compat_v2 flag by default with the normal nodejs_compat flag as of compatibility date 2024-09-23, some users may want to disable this functionality to reduce bundle size while keeping default nodejs_compat for other uses such as vitest.

Additional information

No response
@UpliftMacaw UpliftMacaw added content:edit Request for content edits documentation Documentation edits labels Oct 17, 2024
@github-actions github-actions bot added the product:workers Related to Workers product label Oct 17, 2024
@ibrahimkhled

This comment was marked as spam.

Sign in to view
@Thierryaugusto123

This comment was marked as spam.

Sign in to view
@ToriLindsay
Copy link
Contributor

Hi @jasnell @GregBrimble @mikenomitch - Can someone confirm that this is something we can/should add? If so, I can take a stab at it. Thanks!

@GregBrimble
Copy link
Member

Yes, this should be documented.

@ToriLindsay ToriLindsay linked a pull request Dec 16, 2024 that will close this issue
Open
@ToriLindsay
Copy link
Contributor

Thanks @GregBrimble @jasnell ! Here it is #18765 - Would you mind taking a look and confirming it's correct? Let me know if there's any other context I should add. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasnell jasnell

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@ToriLindsay ToriLindsay

Labels
content:edit Request for content edits documentation Documentation edits product:workers Related to Workers product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added no_nodejs_compat_v2 to notes cloudflare/cloudflare-docs
9 participants
@jasnell @irvinebroque @mikenomitch @GregBrimble @Thierryaugusto123 @ibrahimkhled @UpliftMacaw @ToriLindsay and others