From e1b2c2c1a2a24422463cb71435f999bd81173fea Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Wed, 26 Feb 2025 12:07:57 -0700 Subject: [PATCH 1/3] Lock `cargo-machete` to `0.7.0`, as latest version requires `edition2024` --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6fe308087..130817512 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -59,4 +59,4 @@ jobs: - name: Run cargo machete run: | - [[ ${{ matrix.toolchain }} != 1.82.0 ]] || (cargo install cargo-machete && cargo machete) + [[ ${{ matrix.toolchain }} != 1.82.0 ]] || (cargo install cargo-machete --version 0.7.0 && cargo machete) From e698d3d02ab14bcda25fdde1cab64c846de6db35 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Wed, 26 Feb 2025 12:08:37 -0700 Subject: [PATCH 2/3] Do not fail-fast when one of the toolchains fail --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 130817512..5b310fa22 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -5,6 +5,7 @@ name: build jobs: pingora: strategy: + fail-fast: false matrix: # nightly, MSRV, and latest stable toolchain: [nightly, 1.72.0, 1.82.0] From bcd499994df4fdecaa468ded5bc7c9dae03bf585 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Wed, 26 Feb 2025 12:20:30 -0700 Subject: [PATCH 3/3] Pin additional crates for MSRV tests --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5b310fa22..3f635c6b7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -37,7 +37,7 @@ jobs: - name: Pin crates to versions for MSRV run: | - [[ ${{ matrix.toolchain }} != 1.72.0 ]] || cargo update -p boring --precise 4.13.0 + [[ ${{ matrix.toolchain }} != 1.72.0 ]] || (cargo update -p boring --precise 4.13.0 && cargo update -p litemap --precise 0.7.4 && cargo update -p zerofrom --precise 0.1.5) - name: Run cargo fmt run: cargo fmt --all -- --check