🐛 BUG: Wrangler retries deployments on 4xx errors?

[irvinebroque]

Which Cloudflare product(s) does this pertain to?

Wrangler

What versions are you using?

3.101.0

What operating system and version are you using?

mac latest

Please provide a link to a minimal reproduction

https://github.com/irvinebroque/test-provisioning

Describe the Bug

If I try to deploy a Worker like https://github.com/irvinebroque/test-provisioning that eventually results in an 4xx error like this:

-- START CF API RESPONSE: Bad Request 400
✘ [ERROR] A request to the Cloudflare API (/accounts/ID/workers/scripts/test-provisioning) failed.

  workers.api.error.bucket_not_found [code: 10085]

When I set WRANGLER_LOG="debug" to view what API requests happen under the hood, I see what looks to me like Wrangler retrying deployments?

-- START CF API REQUEST: PUT https://api.cloudflare.com/client/v4/accounts/ID/workers/scripts/test-provisioning?excludeScript=true
-- END CF API REQUEST

-- START CF API RESPONSE: Bad Request 400
-- END CF API RESPONSE
-- START CF API REQUEST: PUT https://api.cloudflare.com/client/v4/accounts/ID/workers/scripts/test-provisioning?excludeScript=true
-- END CF API REQUEST

-- START CF API RESPONSE: Bad Request 400
-- END CF API RESPONSE

-- START CF API REQUEST: PUT https://api.cloudflare.com/client/v4/accounts/ID/workers/scripts/test-provisioning?excludeScript=true
-- END CF API REQUEST

-- START CF API RESPONSE: Bad Request 400
-- END CF API RESPONSE

Is this necessary? Are these retries? If so, why retry on 4xx?

Please provide any relevant error logs

No response

[irvinebroque]

Thanks @penalosa

@nevikashah @korinne probably changes metrics for frequency at which we see these errors returned