From 9b3fd3e86cd9e2c66decc154147ba6a788d8de8d Mon Sep 17 00:00:00 2001 From: Thomas Quandt Date: Wed, 10 Mar 2021 09:24:41 +0100 Subject: [PATCH] Add comment and clean up code (#4876) Signed-off-by: Thomas Quandt --- .../list/list-types/endpoint/endpoint-list.helpers.ts | 2 ++ src/jetstream/cnsi_test.go | 6 ------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts b/src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts index 48b2a33208..1954136782 100644 --- a/src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts +++ b/src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts @@ -172,6 +172,8 @@ export class EndpointListHelper { label: 'Unregister', description: 'Remove the endpoint', createVisible: (row$: Observable) => { + // I think if we end up using these often there should be specific create, + // edit, delete style permissions in the stratos permissions checker return combineLatest([ this.sessionService.userEndpointsNotDisabled(), this.currentUserPermissionsService.can(StratosCurrentUserPermissions.EDIT_ADMIN_ENDPOINT), diff --git a/src/jetstream/cnsi_test.go b/src/jetstream/cnsi_test.go index 620923de0f..635a8f08be 100644 --- a/src/jetstream/cnsi_test.go +++ b/src/jetstream/cnsi_test.go @@ -570,12 +570,6 @@ func TestRegisterWithUserEndpointsEnabled(t *testing.T) { }) }) - - Convey("with UserEndpointsEnabled=disabled", func() { - Convey("register existing user endpoint", func() { - // todo user endpoints should automatically overwritten? - }) - }) }) }