Introduce Json service registry #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add method find_next_serviceID - Add method escape_dots - Add const SERVICE_REGISTRY for service path
Set properties in config templates which are used within the cas specific templates that you can find etc/cas/services/templates.
The attributes defined in allowedAttributes are statically set without the option to configure them. The attributes defined are now set in the DefaultAttributeReleasePolicy.json
# Conflicts: # CHANGELOG.md # app/src/main/java/de/triology/cas/oidc/services/CesOAuthServiceFactory.java # app/src/main/java/de/triology/cas/services/CesServiceManagerConfiguration.java # app/src/main/java/de/triology/cas/services/CesServicesManagerStage.java # app/src/main/java/de/triology/cas/services/CesServicesSpringConfiguration.java # app/src/main/java/de/triology/cas/services/RegistryEtcd.java # app/src/main/java/de/triology/cas/services/attributes/ReturnMappedAttributesPolicy.java # app/src/test/java/de/triology/cas/services/CesServicesManagerStageDevelopmentTest.java # app/src/test/java/de/triology/cas/services/CesServicesManagerStageProductiveTest.java # app/src/test/java/de/triology/cas/services/CesServicesManagerTest.java # app/src/test/java/de/triology/cas/services/attributes/ReturnMappedAttributesPolicyTest.java # docs/gui/release_notes_de.md # docs/gui/release_notes_en.md # resources/etc/cas/config/cas.properties.tpl
… BatsTests and add a check
kahoona77
reviewed
Nov 6, 2024
| # Now replace the random secret in the generated JSON with your extracted secret | ||
| if [ -n "$secret" ]; then | ||
| # Assume the created file name format is <app>-<id>.json | ||
| json_output_file=$(ls -1 "$SERVICE_REGISTRY_PRODUCTION"/${app}-*.json | head -n 1) # Get the most recently created file |
There was a problem hiding this comment.
Maybe you could get the the Service_ID as output from the create-sa.sh-call a few lines above.
This we do not need to "guess" the newest file
| fi | ||
| fi | ||
|
|
||
| echo "Service configuration for $app created." |
There was a problem hiding this comment.
Should we delete the migrated Service form the Dogu-Config?
This way, we could remove the service_accounts/migrated-config, because when there are no services to migrate it will do nothing
Comment on lines
35
to
37
| if [ -n "${LOGOUT_URI+x}" ]; then | ||
| echo "Removing service_accounts/${TYPE}/${SERVICE}/logout_uri key..." | ||
| doguctl config --rm "service_accounts/${TYPE}/${SERVICE}/logout_uri" |
| FQDN=$(doguctl config -g fqdn) | ||
| # escape fqdn to use it within regex | ||
| EFQDN=$(escapeDots "$FQDN") | ||
| SERVICE_ID=$(findNextServiceID "$SERVICE_REGISTRY_PRODUCTION") |
There was a problem hiding this comment.
Why do we need to find a "next" ServiceID?
Can there be more than one JSON-File per service?
| - Einheitliche Verwendung von Service-Accounts sowohl in einer Multinode- als auch Singlenode-Umgebung. | ||
|
|
||
| ### Breaking Change | ||
| - Neu zu installierende Dogus müssen explizit die Erstellung eines Serviceaccounts im CAS über die dogu.json anfordern. Weitere Informationen hierfür finden Sie in der [Entwicklerdokumentation](https://github.com/cloudogu/dogu-development-docs/blob/main/docs/important/relevant_functionalities_de.md#authentifizierung) |
There was a problem hiding this comment.
What about already installed dogus, that do not use CAS-ServiceAccounts?
If I undersrand it correctly, there is currenlty no migration to create service-json.files
Legacy cas service have not been migrated when explicit cas service accounts has been introduces, as they have been accepted as breaking change in multinode. cas service are now migrated to etcd under the key /config/cas/service_accounts/cas/<app>/created
doguctl config remove in while-loop leads to exiting the loop to early ignore exit-code of wget while checking if a dogu is installed Co-authored-by: Nico Franzeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #221
Resolve #228