[#233] Prevent logging of invalid login credentials #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the DefaultDelegatedClientIdentityProviderConfigurationProducer of apereo.cas would print invalid credentials at an invalid login attempt, the password in the log event need to be masked to prevent guessing of actual credentials
|
LGTM. I was able to verify manually that it is now fixed, but the related integration test still fails with the changes of this branch though. Waiting a bit to clear that up and afterwards we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the DefaultDelegatedClientIdentityProviderConfigurationProducer of apereo.cas would print invalid credentials at an invalid login attempt, the password in the log event need to be masked to prevent guessing of actual credentials