Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues that prevented us from using this resource #12

Open
jfuerth opened this issue Jan 16, 2025 · 2 comments · May be fixed by #13
Open

Various issues that prevented us from using this resource #12

jfuerth opened this issue Jan 16, 2025 · 2 comments · May be fixed by #13

Comments

@jfuerth
Copy link

jfuerth commented Jan 16, 2025

Hello!

Thanks for making this OCI Helm Chart resource available as open source.

My team at DNAstack put this resource to use recently, and there were a number of small modifications/improvements we had to make in order for it to meet our needs:

  • We were getting TLS certificate validation errors connecting to the Google Artifact Registry, so we added a ca-certificates update to the Dockerfile
  • The check step was returning errors, but we couldn't tell which registry request those errors were coming from, so we added context info wrapping each call to the oras library.
  • We have some images with abbreviated version strings like 1.0-foo which lack the semver patch field, leading to 404 errors when trying to resolve the normalized version of the tag, eg. 1.0.0-foo, so we changed the code to ensure the original tag string is used for everything except sorting and comparing versions.
  • We ran into configuration errors where check succeeded but in failed because the example in README.md shows the repo name in the wrong config field, so we corrected the example in the README.
  • Finally, we needed to pin our helm chart to a non-current version, so we changed the check step to provide the 10 latest versions on the initial check. As a side effect, we also improved the check logic so it returns all versions newer than the previous latest version, so there are no gaps in the list of versions available through the resource.

All the above changes are on this branch in our fork of the repo. Would you be open to having us contribute them back to this project?

@SuperSandro2000
Copy link
Contributor

Of course! The project is governed by an Apache 2.0 license and I don't think we have any special cla or so. It could take a couple of days to get a review in but since it seems like you already tested the changes in production they should be working as expected.

@jfuerth jfuerth linked a pull request Jan 17, 2025 that will close this issue
@jfuerth
Copy link
Author

jfuerth commented Jan 17, 2025

That's great, thanks! I've sent the PR and I look forward to your review.

@kengou kengou linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants