You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for making this OCI Helm Chart resource available as open source.
My team at DNAstack put this resource to use recently, and there were a number of small modifications/improvements we had to make in order for it to meet our needs:
We were getting TLS certificate validation errors connecting to the Google Artifact Registry, so we added a ca-certificates update to the Dockerfile
The check step was returning errors, but we couldn't tell which registry request those errors were coming from, so we added context info wrapping each call to the oras library.
We have some images with abbreviated version strings like 1.0-foo which lack the semver patch field, leading to 404 errors when trying to resolve the normalized version of the tag, eg. 1.0.0-foo, so we changed the code to ensure the original tag string is used for everything except sorting and comparing versions.
We ran into configuration errors where check succeeded but in failed because the example in README.md shows the repo name in the wrong config field, so we corrected the example in the README.
Finally, we needed to pin our helm chart to a non-current version, so we changed the check step to provide the 10 latest versions on the initial check. As a side effect, we also improved the check logic so it returns all versions newer than the previous latest version, so there are no gaps in the list of versions available through the resource.
All the above changes are on this branch in our fork of the repo. Would you be open to having us contribute them back to this project?
The text was updated successfully, but these errors were encountered:
Of course! The project is governed by an Apache 2.0 license and I don't think we have any special cla or so. It could take a couple of days to get a review in but since it seems like you already tested the changes in production they should be working as expected.
Hello!
Thanks for making this OCI Helm Chart resource available as open source.
My team at DNAstack put this resource to use recently, and there were a number of small modifications/improvements we had to make in order for it to meet our needs:
1.0-foo
which lack the semver patch field, leading to 404 errors when trying to resolve the normalized version of the tag, eg.1.0.0-foo
, so we changed the code to ensure the original tag string is used for everything except sorting and comparing versions.check
succeeded butin
failed because the example in README.md shows the repo name in the wrong config field, so we corrected the example in the README.check
step to provide the 10 latest versions on the initial check. As a side effect, we also improved thecheck
logic so it returns all versions newer than the previous latest version, so there are no gaps in the list of versions available through the resource.All the above changes are on this branch in our fork of the repo. Would you be open to having us contribute them back to this project?
The text was updated successfully, but these errors were encountered: