-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to specify artifact name #44
Comments
Hey @goruha If you'd like I could propose a pull request for this 😉 |
@TheBatman09, thanks for the feature request. |
Voila ! |
Hi @TheBatman09, Thank you for bringing this up! Your use case makes sense, and I can see how the current hashing mechanism could cause conflicts when trying to store the same data twice with different step names. I could say about some solutions in my mind:
|
Hey thanks for your answer, actually I forked to be able to use it back in the days and I did made a pr with solution 1 : https://github.com/cloudposse/github-action-matrix-outputs-write/pull/45/files |
Use Case
Hello guys, I've started using this action and I came across the following issue: I have some dynamically retrieved data that I write with a step name and a matrix name. Then I retrieve some data again and try to write it with a different step name but same matrix name. And here when the data is the same for first and second time I get an error saying the artifact already exists. By looking at the code it looks like that's because the artifact name used is a hash of the content and in my case the content is the same in both cases.
Expected Behavior
I expect to be able to write the same data twice with a different step name.
Describe Ideal Solution
I think the ideal solution would be to add a parameter to the action to allow the user to chose the key used to store the artifact and/or also include the step name in the hash to allow storing twice the same data if it has a different step name.
Bonus
It seems like a fairly easy fix, i'd be happy to contribute if needed
The text was updated successfully, but these errors were encountered: