Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build amd64 version for Linux #36

Open
Nuru opened this issue Feb 21, 2022 · 2 comments
Open

Build amd64 version for Linux #36

Nuru opened this issue Feb 21, 2022 · 2 comments
Assignees

Comments

@Nuru
Copy link
Contributor

Nuru commented Feb 21, 2022

Versions 0.10.0 and 0.10.1 was released with 386 and amd64 versions for Darwin and FreeBSD, but not Linux. Linux amd64 was included in releases v0.9.0 and earlier. Please include Linux amd64 in the releases again.

@Nuru
Copy link
Contributor Author

Nuru commented Feb 21, 2022

Apparently this is some sort of transient error with uploading assets. I was able to get the v0.10.1 assets to upload (renamed originally released assets *-r0 because the workflow would not overwrite them), but after 3 further attempts I have still not been able to get the v0.10.0 assets to upload. I opened a ticket with GitHub support about it. Note this also affected github-status-updater

@nitrocode
Copy link
Member

I see the linux amd64 release in the latest version

https://github.com/cloudposse/github-commenter/releases/tag/0.14.1

Looking at the other releases, it's bizarre that some releases have 18 assets and some have as few as 3.

https://github.com/cloudposse/github-commenter/releases

It would be good to use .goreleaser file and the same action as atmos to keep the binaries consistent.

https://github.com/cloudposse/atmos/blob/master/.goreleaser.yml

https://github.com/cloudposse/atmos/blob/master/.github/workflows/build.yml#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants