From a804b9323cd1a2de3a6400d9c9c14a35a4a01ddb Mon Sep 17 00:00:00 2001 From: Alfredo Gil Mira Date: Fri, 14 Apr 2023 10:33:20 +0200 Subject: [PATCH 1/5] feat: adding the option to disable ttl once it was enable before --- main.tf | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/main.tf b/main.tf index cda1c96..30fcb2b 100644 --- a/main.tf +++ b/main.tf @@ -114,13 +114,10 @@ resource "aws_dynamodb_table" "default" { } } - dynamic "ttl" { - for_each = var.ttl_enabled ? [1] : [] - content { - attribute_name = var.ttl_attribute + ttl { enabled = var.ttl_enabled + attribute_name = var.ttl_enabled ? var.ttl_attribute : "" } - } tags = var.tags_enabled ? module.this.tags : null } From 6b359bf8189ed9c7c50251c7f7cb55efb093da1e Mon Sep 17 00:00:00 2001 From: alfredo-gil <85618455+alfredo-gil@users.noreply.github.com> Date: Mon, 17 Apr 2023 10:59:53 +0200 Subject: [PATCH 2/5] fix: add correct condition --- main.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main.tf b/main.tf index 30fcb2b..75559b8 100644 --- a/main.tf +++ b/main.tf @@ -115,8 +115,8 @@ resource "aws_dynamodb_table" "default" { } ttl { - enabled = var.ttl_enabled - attribute_name = var.ttl_enabled ? var.ttl_attribute : "" + enabled = var_ttl_attribute != "" : var.ttl_enabled ? false + attribute_name = var.ttl_attribute } tags = var.tags_enabled ? module.this.tags : null From cc556ced8ed02d9c9121a7c5eb5e5da566925b11 Mon Sep 17 00:00:00 2001 From: alfredo-gil <85618455+alfredo-gil@users.noreply.github.com> Date: Mon, 17 Apr 2023 11:03:25 +0200 Subject: [PATCH 3/5] fix: fix condition --- main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.tf b/main.tf index 75559b8..3db8467 100644 --- a/main.tf +++ b/main.tf @@ -115,7 +115,7 @@ resource "aws_dynamodb_table" "default" { } ttl { - enabled = var_ttl_attribute != "" : var.ttl_enabled ? false + enabled = var_ttl_attribute != "" ? var.ttl_enabled : false attribute_name = var.ttl_attribute } From 794571dc734335eb604c5c987f7b064efff1d841 Mon Sep 17 00:00:00 2001 From: alfredo-gil <85618455+alfredo-gil@users.noreply.github.com> Date: Mon, 17 Apr 2023 11:05:21 +0200 Subject: [PATCH 4/5] fix typo --- main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.tf b/main.tf index 3db8467..4fe9afc 100644 --- a/main.tf +++ b/main.tf @@ -115,7 +115,7 @@ resource "aws_dynamodb_table" "default" { } ttl { - enabled = var_ttl_attribute != "" ? var.ttl_enabled : false + enabled = var.ttl_attribute != "" ? var.ttl_enabled : false attribute_name = var.ttl_attribute } From 270e5bba04427c6b5d93a613d182f614544019a5 Mon Sep 17 00:00:00 2001 From: Alfredo Gil Mira Date: Thu, 31 Aug 2023 11:24:10 +0200 Subject: [PATCH 5/5] feat: add terraform fmt --- main.tf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/main.tf b/main.tf index d272953..642fdcf 100644 --- a/main.tf +++ b/main.tf @@ -115,9 +115,9 @@ resource "aws_dynamodb_table" "default" { } ttl { - enabled = var.ttl_attribute != "" ? var.ttl_enabled : false - attribute_name = var.ttl_attribute - } + enabled = var.ttl_attribute != "" ? var.ttl_enabled : false + attribute_name = var.ttl_attribute + } tags = var.tags_enabled ? module.this.tags : null }