add(outputs): paramter_group_name and option_group_name #181
Conversation
There was a problem hiding this comment.
@flightlesstux thanks you.
Please see comments, and please also run
make init
make github/init
make readme
and commit the changes
|
@aknysh are we still using |
Thank you for your help @aknysh. |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
@joe-niland I'm not sure, but the command did update the files in |
| engine_name = var.engine | ||
| major_engine_version = local.major_engine_version | ||
| tags = module.this.tags | ||
| major_engine_version = var.major_engine_version |
There was a problem hiding this comment.
why changing these two lines
major_engine_version = var.major_engine_version
tags = var.tags
|
|
||
| name_prefix = "${module.this.id}${module.this.delimiter}" | ||
| name = var.option_group_name | ||
| count = 1 |
There was a problem hiding this comment.
if count is one, not need to set tit to 1
| count = length(var.option_group_name) == 0 && module.this.enabled ? 1 : 0 | ||
|
|
||
| name_prefix = "${module.this.id}${module.this.delimiter}" | ||
| name = var.option_group_name |
There was a problem hiding this comment.
hmm, this completely changes the behavior of the module.
Before, if var.option_group_name was provided, it was used as an existing option grouo and no new option grouo was created.
After this change, var.option_group_name is the name of the new option group to create.
Also, name_prefix was useful to create many option groups for the same cluster.
@flightlesstux can you maybe update it to maintain backwards compatibility? (otherwise, it will break many existing deployments)
|
💥 This pull request now has conflicts. Could you fix it @flightlesstux? 🙏 |
|
PR closed due to not necessary commits. Sorry for this. |
mergify
bot
removed
conflict
what
Output values are added.
why
We need to pass the variables to the RDS.
db_options variable logic is also fixed.
references
n/a