Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors extending the annotation spans #45

Open
EgoLaparra opened this issue Jul 25, 2019 · 1 comment
Open

Errors extending the annotation spans #45

EgoLaparra opened this issue Jul 25, 2019 · 1 comment
Assignees

Comments

@EgoLaparra
Copy link
Contributor

The errors caught by Keith are produced by wrong or incomplete identifications. One is solved with #44, but the other one cannot be solved because we expand only to "O" characters:

      "timexes" : [ {
        "@type" : "TimeExpression",
        "@id" : "_:TimeExpression_13",
        "startOffset" : 3238,
        "endOffset" : 3247,
        "text" : "Oct. 2017",
        "intervals" : [ {
          "@type" : "TimeInterval",
          "@id" : "_:TimeInterval_8",
          "start" : "0017-10-02T00:00",
          "end" : "0017-10-03T00:00"
        } ]
      } ]

In this case, "2" is identified as Day-Of-Month and "017" as Year. This is why the resulting intervals is [0017-10-02T00:00, 0017-10-03T00:00).

@bethard
Copy link
Collaborator

bethard commented Jul 25, 2019

I'm guessing this error is because we never saw Month+Year in the training data, always Month+Day+Year. If that's the case, the right fix for this is probably to generate more artificial training data to provide such examples.

I could imagine a bunch of heuristics to fix this (e.g., never let a year be only 3 digits), but they all seem hacky, and don't get to the root of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants