Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up taxonomies #332

Open
adarshp opened this issue Dec 2, 2022 · 2 comments
Open

Clean up taxonomies #332

adarshp opened this issue Dec 2, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@adarshp
Copy link
Member

adarshp commented Dec 2, 2022

Given that we cannot compose Odin taxonomies in the same way we can Odin rules (see clulab/processors#686), I think we should have separate taxonomy files for each study.

@remo-help - since you are working on looking at the Study 4 pilot data, perhaps you can create a separate Study 4 taxonomy file that does not include the stuff that is specific to Studies 2 and 3 (I'm thinking mainly the room names, but there are other things too)

And I think it would be good if taxonomy files lived in a separate folder rather than being combined with the rules in the grammars folder. Perhaps we could have something like org/clulab/asist/taxonomies? Would that work?

@adarshp adarshp added the enhancement New feature or request label Dec 2, 2022
@remo-help
Copy link
Collaborator

We can separate the taxonomies and load them through different master files. I can start on this as part of the study 4 investigation and create a new taxonomy for those rules

@adarshp
Copy link
Member Author

adarshp commented Dec 3, 2022

Thanks @remo-help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants