Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open and closing cades give inverted messages. #8640

Open
cm13-issue-bot opened this issue Mar 2, 2025 · 4 comments · May be fixed by #8669
Open

Open and closing cades give inverted messages. #8640

cm13-issue-bot opened this issue Mar 2, 2025 · 4 comments · May be fixed by #8669
Assignees
Labels
Good First Issue Good for newcomers Oversight Test your code rigorously only for you to overlook something ultra obvious

Comments

@cm13-issue-bot
Copy link

Testmerges

#8442: 'Removes devour, replaces it with haul. #2737 Revival' by casperr04 at commit 385b1c4730
#7645: 'adds poll subsystem, entities and ui' by hry-gh at commit ddd2f66fd9
#8378: 'Yautja Ship - Complete Remake & more...' by Zenith00000 at commit 0cdba4c8ed
#8492: 'chunk tgui topic payloads on 516' by hry-gh at commit f003f713b4
#8181: 'Nerfs playable huggers' by Git-Nivrak at commit 9d320b716f
#8606: 'refactors audio player (by adding a 516 version with nicer code)' by hry-gh at commit c08ed16336
#7816: 'Hostile Survivor Rework Revival' by BOBAMAx at commit 3cbca27874

Round ID

26660

Description of the bug

Opening a cade says you flip the [src] closed.

What's the difference with what should have happened?

Reverse that.

How do we reproduce this bug?

  1. Open cade
  2. It says you closed it
  3. Vice versa.

Attached logs

You flip the folding plasteel barricade closed.
You flip the folding plasteel barricade open.

Additional details

  • Author: AnonHault
  • Admin: SmellyHippie
  • Note: None
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Mar 2, 2025
@Red-byte3D
Copy link
Member

its open because.......you open it up....

@HaultyAnonie
Copy link
Contributor

its open because.......you open it up....

No, if you open it, it will say you closed it.

@Zonespace27
Copy link
Contributor

Zonespace27 commented Mar 3, 2025

The code behind it is inverted likely because "closed" var being TRUE means the cade is open, and it being FALSE means it is closed.

@LC4492 LC4492 added Good First Issue Good for newcomers Oversight Test your code rigorously only for you to overlook something ultra obvious and removed Bug Admin events aren't bugs labels Mar 4, 2025
@Willzadl
Copy link
Contributor

Willzadl commented Mar 5, 2025

The code behind it is inverted likely because "closed" var being TRUE means the cade is open, and it being FALSE means it is closed.

it can be said that arguably, with reference to the barricade itself, closing the barricade would mean folding it up and opening it would mean pulling the protection panel up

nonetheless we should probably use the gap itself as the reference point even though its (very) technically incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Oversight Test your code rigorously only for you to overlook something ultra obvious
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants