Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage multi-event banner #604

Closed
2 tasks done
cjyabraham opened this issue Sep 23, 2022 · 20 comments
Closed
2 tasks done

Homepage multi-event banner #604

cjyabraham opened this issue Sep 23, 2022 · 20 comments
Assignees

Comments

@cjyabraham
Copy link
Collaborator

cjyabraham commented Sep 23, 2022

This follows on the work from #570. Implement a slider to display all qualifying events on the homepage. Slider will have arrows to allow user to go between events and may also possibly move automatically when there is no guiding user input. Qualifying events are those that are upcoming and have the desktop and mobile assets set. Here are the basic designs, however, there are some points that need discussing and finalizing:
Screen Shot 2022-09-23 at 1 52 12 PM

Steps:

  • Finalize designs
  • Implement

Dimensions for Event banner images:

  • Desktop - 2400px x 840px
  • Mobile - 900px x 1100px
@thetwopct
Copy link
Collaborator

Lets get the designs finalised for the slider - personally I prefer arrows inside the container, and this also works better on mobile.

@GarethAcidWorks do we want to signify the number of sliders (typically this is done with dots under or over the bottom of the slider). If so we need an active and inactive state.

@GarethAcidWorks
Copy link

GarethAcidWorks commented Sep 25, 2022 via email

@thetwopct
Copy link
Collaborator

@GarethAcidWorks Just wondering if there is any progress on this slider design. From Figma:

CleanShot 2022-10-17 at 15 43 47@2x

  • The arrow controls floating over the top of the banner look great, think that's much better than them sitting outside the container.
  • It took me a while to see the lines that indicate the slider count - they are also easy to miss on artwork that's not Detroit (i.e. Valencia), so I wonder if this needs a rethink (they could sit below the banner maybe).
  • If you can provide a mobile mockup too showing arrows and slide indicator that will make implementation easier.
  • Lets confirm the text/heading style above the banner too - previously suggested "Upcoming Events & Other Activities" but I feel like we could drop "Other Activities" as this will be displaying only events.

Thanks

@GarethAcidWorks
Copy link

GarethAcidWorks commented Oct 17, 2022 via email

@thetwopct
Copy link
Collaborator

thetwopct commented Oct 17, 2022

@GarethAcidWorks No further thinking on content is required - the banner is for CNCF events and has been built as discussed, signed off and implemented in this issue.

@KTan1226
Copy link

Hi @GarethAcidWorks - As @thetwopct flagged, let's move forward with the plan as is.

@cjyabraham
Copy link
Collaborator Author

Could we also get assets for the following events as @KTan1226 has outlined:

Note that as soon as Kubecon NA has passed on the 28th the current event banner will disappear unless we've loaded up assets for future events.

As a reminder, dimensions for Event banner images need to be
Desktop - 2400px x 840px
Mobile - 900px x 1100px

@GarethAcidWorks
Copy link

GarethAcidWorks commented Oct 19, 2022 via email

@thetwopct thetwopct added the needs design requires design to move forward label Oct 20, 2022
@GarethAcidWorks
Copy link

Hi all, here are the banners for Kube Day Japan.
We do not have artwork for KCCNC Europe yet.
Perhaps we can implement Detroit + Japan for now as a test.

Regarding the interface:

• I do feel the title and the dividing lines helps us bring some context / purpose / engagement to the page after a couple of scrolls. Currently the title is improved to 'Events & more' but have to take another look at that when Charlie is free.

• Regarding the thin line counters, I tried them below the artwork and it's creating awkward space. So i would recommend either of the following:

a) Keep them within the image, they are only a gentle suggestion that there is more content
b) Don't use them at all.

For the actual behavior of the banner, having it switch itself every 3 seconds, and also the ability to click would keep the page feeling alive

CNCF_Ad Canvas_01gd_D_2400 x 840
CNCF_Ad Canvas_01gd_M_900 x 1100

@thetwopct
Copy link
Collaborator

@GarethAcidWorks Thanks.

  • Can you provide a mobile mockup of the banner including thin line + text above the banner
  • The text to use above the banner should probably be "Forthcoming Events" - as discussed this section will show events, so " & More" is not relevant. We can refine later with @Charley-Mann if needed.
  • If the thin line slide indicators are hard to see over the banners, typically sliders use dots to signify the number of banners, this would be bolder and possibly easier to see - is that worth exploring?

@thetwopct
Copy link
Collaborator

@GarethAcidWorks

  • I've guessed on the mobile layout - I've had to drop down the arrow position to 55% from the top so they didn't cover the logo.

2022-10-23-204508

  • When there is only one event the text is "The next CNCF event"

2022-10-23-204952

  • 3000ms was a bit too quick for the sliders to move, so I made it 5000ms
  • The KubeDay Japan mobile banner provided is the wrong size, can you make it the same as the Kubecon banner, or adjust all banners in future to be a consistent size? As you can see the two sizes don't look good:

2022-10-23-204709

thetwopct added a commit that referenced this issue Oct 23, 2022
@thetwopct
Copy link
Collaborator

Switched the text above the banner(s) to "Upcoming Event" and "Upcoming Events" if multiple

2022-10-24-113758@2x

2022-10-24-113822

@KTan1226
Copy link

Looks great, thank you!

cjyabraham pushed a commit that referenced this issue Oct 24, 2022
@cjyabraham
Copy link
Collaborator Author

deployed

@GarethAcidWorks
Copy link

GarethAcidWorks commented Oct 25, 2022

Thanks for this, a couple of refinements on the live version please.

  1. Arrows should be positioned in the centre. Currently they are too far down (See below)
  2. Let's just use a fade (opacity) transition when you click the arrows, please set the time to fast pace (.5 seconds or less). The swiping is too clunky / harsh.

Thanks!

Screenshot 2022-10-24 at 23 51 copy

@thetwopct
Copy link
Collaborator

  1. Ok no problems, I am moved it precisely in to the middle (see Figma for measurements using screenshot). I think that makes the Detroit banner look misaligned as the Detroit text is not centred...

2022-10-25-121759

2022-10-25-121830@2x

  1. Added fade effect instead of swipe

2022-10-25-122115

@thetwopct thetwopct removed the needs design requires design to move forward label Oct 25, 2022
@GarethAcidWorks
Copy link

GarethAcidWorks commented Oct 29, 2022 via email

@thetwopct
Copy link
Collaborator

@GarethAcidWorks Please see the thread above, I have left you a note on the sizing.

The KubeDay Japan mobile banner provided is the wrong size, can you make it the same as the Kubecon banner, or adjust all banners in future to be a consistent size? As you can see the two sizes don't look good:

@GarethAcidWorks
Copy link

GarethAcidWorks commented Oct 29, 2022 via email

@thetwopct
Copy link
Collaborator

thetwopct commented Oct 29, 2022

As already outlined several times to you, this has been signed off and developed as an event banner. We already have spaces in the mega menu (which is on every page) to highlight reports. The banner and development behind it will allow us to syndicate event banners across our sub-sites (at your request) and easily update and manage them all from one central place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants