Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort bear #2339

Closed
palash25 opened this issue Mar 14, 2018 · 8 comments
Closed

Add isort bear #2339

palash25 opened this issue Mar 14, 2018 · 8 comments

Comments

@palash25
Copy link
Member

palash25 commented Mar 14, 2018

isort is a nice tool to sort imports in python files. We should have this integrated with coala. If a linter bear integration is not possible then maybe we can write a native bear

https://github.com/timothycrosley/isort#readme

@gitmate-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #301 (Add xo bear), #275 (Add gotype bear), #201 (Add TSLint Bear), #2152 (Add ktlint Bear), and #1638 (Add nginxBear).

@palash25
Copy link
Member Author

area/ci label should be removed.
Btw whats wrong with @gitmate-bot ?

@ajeetdsouza
Copy link

ajeetdsouza commented Mar 15, 2018

Could I work on this, please?

@palash25
Copy link
Member Author

Sure go ahead @ajeetdsouza since you have already commented a maintainer will assign you as soon as possible. Meanwhile you can start working on this. If still not assigned for more than a day then ask on gitter for assignment.

@ajeetdsouza
Copy link

Doesn't this already do this, though?

@Makman2
Copy link
Member

Makman2 commented Mar 17, 2018

isort is a different tool, I guess we want to have it too 👍

@ajeetdsouza
Copy link

I think this bear already uses the isort tool:
https://github.com/coala/coala-bears/blob/master/bears/python/PyImportSortBear.py
They're using the SortImports class from https://github.com/timothycrosley/isort/blob/develop/isort/isort.py

@Makman2
Copy link
Member

Makman2 commented Mar 17, 2018

Oh indeed, I always thought PyImportSort is an own tool 😅 Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants