Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refractoring in labhub tests #594

Open
nvzard opened this issue Jul 31, 2018 · 11 comments
Open

Minor refractoring in labhub tests #594

nvzard opened this issue Jul 31, 2018 · 11 comments

Comments

@nvzard
Copy link
Member

nvzard commented Jul 31, 2018

Do minor changes in labhub_tests as asked here #572 (review) (see below)

difficulty/low

@ssg2526
Copy link

ssg2526 commented Jul 31, 2018

i am a beginner, can i help?

@nvzard
Copy link
Member Author

nvzard commented Jul 31, 2018 via email

@ssg2526
Copy link

ssg2526 commented Aug 1, 2018

@nvzard, i was not assigned any issues till now. which issue i should work on?

@nvzard
Copy link
Member Author

nvzard commented Aug 1, 2018

@ssg2526 you should get yourself assigned to a difficulty/newcomer issue which you understand. I set the difficulty of this issue as low but gitmate-bot missed it maybe :3
I think this issue would be a little tricky for a newcomer, but if you understand this you can get yourself assigned otherwise look for another newcomer issue :)

@ssg2526
Copy link

ssg2526 commented Aug 1, 2018

@nvzard, Thanks for the help.

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2018

Specifically

self.assertEqual(self.labhub.TEAMS, self.teams)

This should use assertIs instead of assertEqual

in test_invite_cmd

mock_dict['is_room_member'].return_value = True

it is already True, and this should be removed

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2018

@ssg2526 , you have been sent an invite to join @coala . Please accept it so we can assign this issue to you.

@ssg2526
Copy link

ssg2526 commented Aug 8, 2018

@jayvdb, I have joined the coala

@ssg2526
Copy link

ssg2526 commented Aug 8, 2018

@jayvdb please assign this issue to me

@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

Assigned. sorry we tend to respond better on gitter

@sudonitin
Copy link

@Makman2 @li-boxuan Please assign me this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants