Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ban command needs 100% branch test coverage #610

Open
jayvdb opened this issue Aug 8, 2018 · 3 comments · May be fixed by #669
Open

ban command needs 100% branch test coverage #610

jayvdb opened this issue Aug 8, 2018 · 3 comments · May be fixed by #669

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 8, 2018 •
edited
Loading

plugins/ban.py 37 0 18 6 89% 21->24, 38->36, 42->36, 56->59, 72->70, 76->70

https://travis-ci.org/jayvdb/corobo/builds/413532424
@jayvdb jayvdb assigned sladyn98 and unassigned nvzard Nov 7, 2018
@sladyn98
Copy link

sladyn98 commented Nov 8, 2018 •
edited
Loading

@jayvdb Can i know how are the individual test being conducted for each file specified in the travis.yml .Because from what i understand there are a specific number of files for which travis is conducting tests.

@Anmolbansal1
Copy link

@jayvdb, please assign this issue to me.

codehobbyist06 pushed a commit to codehobbyist06/corobo that referenced this issue Apr 27, 2021
Fix ban_test to have 100% coverage
adb0a4e 
plugins/ban.py: Update to handle new cases

Updates ban.py handling some more cases

tests/ban_test.py: Add new mocks

Adds new mocks to get 100% test coverage
for ban.py

setup.cfg: Remove ban.py from omit

Removes ban.py from the omit section

Fixes coala#610
@codehobbyist06 codehobbyist06 linked a pull request Apr 27, 2021 that will close this issue
Open
6 tasks
@codehobbyist06
Copy link
Contributor

I have created a pull request referencing this issue. Can u pls check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ban_test to have 100% coverage codehobbyist06/corobo
5 participants
@jayvdb @nvzard @sladyn98 @Anmolbansal1 @codehobbyist06