Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting perfect Lighthouse score #55

Open
blazeu opened this issue Dec 9, 2017 · 7 comments
Open

Getting perfect Lighthouse score #55

blazeu opened this issue Dec 9, 2017 · 7 comments

Comments

@blazeu
Copy link
Member

blazeu commented Dec 9, 2017

Lighthouse analyzes web apps and web pages, collecting modern performance metrics and insights on developer best practices.

https://github.com/GoogleChrome/lighthouse

This is our current Lighthouse audit result: https://u.teknik.io/4SV0f.html

This task is for increasing our Lighthouse score, multiple students can take this task.

For now, don't worry about service worker / offline support, I think we will have another task for that.

Your build must be rebased and have at least one more audit passed than master.

@jayvdb
Copy link
Member

jayvdb commented Dec 9, 2017

u.teknik.io/4SV0f.html

connection failure. They fail too?

@coala coala deleted a comment from gitmate-bot Dec 9, 2017
@myfrom
Copy link
Contributor

myfrom commented Dec 10, 2017

Can I take the Best Practises and Accessibility? I could also try my best at Performance.

For GCI task

@blazeu
Copy link
Member Author

blazeu commented Dec 10, 2017

@myfrom Sure.

@myfrom
Copy link
Contributor

myfrom commented Dec 11, 2017

Just a question: Do you have any favicon? It's not really related to the task but I saw you're setting og:image to GCI logo but leaving favicon blank and I think we could set GCI logo as favicon too.

@blazeu
Copy link
Member Author

blazeu commented Dec 11, 2017

Yes, of course.

@myfrom
Copy link
Contributor

myfrom commented Dec 11, 2017

I have one more question: I have created favicon.ico, but I'm not sure how to tell the build script to put it into the output, how should I do that?

@blazeu
Copy link
Member Author

blazeu commented Dec 11, 2017

Yes, while you're at it, modify it so that it copies the content of static into out/ not out/static so that we're able to put something in the root folder of out such as favicon or manifest.

Don't forget to split your commit accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants