Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Out doesnt work #133

Open
jayvdb opened this issue Jul 29, 2018 · 6 comments
Open

Sign Out doesnt work #133

jayvdb opened this issue Jul 29, 2018 · 6 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 29, 2018

Signing out seems to have no effect at all.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 29, 2018

The avatar stays.

It seems the token also keeps being used.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 29, 2018

It seems that the same problem exists on the upstream repos too.

@li-boxuan
Copy link
Member

li-boxuan commented Jul 29, 2018

It works for me, occasionally. Let me try to investigate if there is a bug around it.

UPDATE: hmmm, I do not find any bug. When I refresh the page, I sign out. If I don't refresh, sometimes I need to click that button twice to get signed out.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 30, 2018

I've tried in another browser , Falkon and Firefox, and lots of refreshing, I am not logged out.

To force a log out, I need to quickly catch the "Log in" button, and enter an invalid token, but that causes lots of extra bugs.

The avatar should at least change, and log in settings become available, without a refresh. That could be the first fix.

@ashwini0529
Copy link
Member

ashwini0529 commented Oct 22, 2018

I was trying to replicate the issue. I also experienced the same thing.
But while fetching data, if you click logout, it shows something like this.
screenshot 2018-10-22 at 11 00 10 pm

@li-boxuan
Copy link
Member

li-boxuan commented Oct 23, 2018

I was trying to replicate the issue. I also experienced the same thing.

Do you want to take this issue? @ashwini0529

But while fetching data, if you click logout, it shows something like this.

That might be another bug I guess. Probably the error message is not showing in the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants