Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.js: Exclude mentors on disabled projects #710

Closed
wants to merge 1 commit into from
Closed

app.js: Exclude mentors on disabled projects #710

wants to merge 1 commit into from

Conversation

zjxiaohan
Copy link

Closes #707

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.     It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@TravisBuddy
Copy link

Travis tests have failed

Hey @zjxiaohan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci 
Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][21:45:51] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][21:45:53] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][21:45:53] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][21:45:53] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][21:45:53] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][21:45:53] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][21:45:53] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
Executing section html...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...
TravisBuddy Request Identifier: 97398a50-2a58-11e9-9562-95bccb7073f8

li-boxuan
li-boxuan approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayvdb
Copy link
Member

jayvdb commented Aug 25, 2019

Contributor deleted their repository, so PR has to be abandoned.

@jayvdb jayvdb closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-boxuan li-boxuan li-boxuan approved these changes

Assignees

@zjxiaohan zjxiaohan

Labels
difficulty/newcomer importance/low process/approved size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mentor list should not include mentors on disabled projects
5 participants
@zjxiaohan @TravisBuddy @jayvdb @li-boxuan @gitmate-bot